]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile/internal/types2: review of decl.go
authorRobert Griesemer <gri@golang.org>
Mon, 29 Mar 2021 18:36:44 +0000 (11:36 -0700)
committerRobert Griesemer <gri@golang.org>
Wed, 31 Mar 2021 04:13:28 +0000 (04:13 +0000)
commit34fb2b2ed5687ec85aa8c1db1481bb4f31b35b29
treea7136a5cc24af882b42e2b8eebe876beb372b863
parent0e8a72b62efa44fa01eccb94d47a051366cb6d17
cmd/compile/internal/types2: review of decl.go

The changes between (equivalent, and reviewed) go/types/decl.go
and decl.go can be seen by comparing patchset 1 and 2. The actual
changes are removing the "// UNREVIEWED" marker and a minor comment
update.

The primary differences to go/types/decl.go are:
- use of syntax rather than go/ast package
- use of error_ objects to collect follow-on error info
- use of check.conf.Trace rather than global trace flag
- more aggressively marking variables as used in the presence errors
- not using a walkDecl abstraction for const/var/type declarations

Change-Id: I5cf26779c9939b686a3dbaa4d38fdd0c154a92ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/305570
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/types2/decl.go