]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: mark R16, R17 clobbered for non-standard calls on ARM64
authorCherry Zhang <cherryyz@google.com>
Fri, 28 Jun 2019 13:30:36 +0000 (09:30 -0400)
committerKeith Randall <khr@golang.org>
Thu, 25 Mar 2021 21:30:55 +0000 (21:30 +0000)
commit11b4aee05bfe83513cf08f83091e5aef8b33e766
tree3c64e6bd23610eed0d1c664c4d7b37d6ab647b4b
parent5834ce1dd770c848342ec357a8317a4eb2d88aca
cmd/compile: mark R16, R17 clobbered for non-standard calls on ARM64

On ARM64, (external) linker generated trampoline may clobber R16
and R17. In CL 183842 we change Duff's devices not to use those
registers. However, this is not enough. The register allocator
also needs to know that these registers may be clobbered in any
calls that don't follow the standard Go calling convention. This
include Duff's devices and the write barrier.

Fixes #32773, second attempt.

Change-Id: Ia52a891d9bbb8515c927617dd53aee5af5bd9aa4
Reviewed-on: https://go-review.googlesource.com/c/go/+/184437
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Meng Zhuo <mzh@golangcn.org>
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Meng Zhuo <mzh@golangcn.org>
src/cmd/compile/internal/ssa/gen/ARM64Ops.go
src/cmd/compile/internal/ssa/opGen.go
src/runtime/asm_arm64.s