]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.9] cmd/go: clean up x.exe properly in TestImportMain
authorRuss Cox <rsc@golang.org>
Tue, 17 Oct 2017 19:10:59 +0000 (15:10 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 25 Oct 2017 20:23:39 +0000 (20:23 +0000)
commit0758d2b9da81f45c758d028570782194db92f6be
treedee6dba2d58648a901397589879d9e222681b059
parentd487b15a61eee87c304277842a4624dca0c6bddd
[release-branch.go1.9] cmd/go: clean up x.exe properly in TestImportMain

More generally I'm concerned about these tests using
$GOROOT/src/cmd/go as scratch space, especially
combined wtih tg.parallel() - it's easy to believe some other
test might inadvertently also try to write x.exe about the
same time. This CL only solves the "didn't clean up x.exe"
problem and leaves for another day the "probably shouldn't
write to cmd/go at all" problem.

Fixes #22266.

Change-Id: I651534d70e2d360138e0373fb4a316081872550b
Reviewed-on: https://go-review.googlesource.com/71410
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/71530
src/cmd/go/go_test.go