[dev.link] all: clean up some TODOs

Change-Id: Iae1ca888729014b6fec97d7bd7ae082dbceb9fe5
Reviewed-on: https://go-review.googlesource.com/c/go/+/204837
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>

diff --git a/src/cmd/internal/goobj2/objfile.go b/src/cmd/internal/goobj2/objfile.go
index e10ce43833efca233a87b533fc5fbbec966cc95e..4c364b0c542f98eaed34359d751d03e457cb26ad 100644 (file)
--- a/src/cmd/internal/goobj2/objfile.go
+++ b/src/cmd/internal/goobj2/objfile.go
@@ -33,7 +33,7 @@ import (
 //    Autolib  [...]stringOff // imported packages (for file loading) // TODO: add fingerprints
 //    PkgIndex [...]stringOff // referenced packages by index
 //
-//    DwarfFiles [...]stringOff // XXX as a separate block for now
+//    DwarfFiles [...]stringOff
 //
 //    SymbolDefs [...]struct {
 //       Name stringOff

diff --git a/src/cmd/internal/obj/sizeof_test.go b/src/cmd/internal/obj/sizeof_test.go
index ac65143b6b077cacb711e19f7a33e43baa836e0f..b5e170c6945f37b2c4f9edc7b2a72123e3e69668 100644 (file)
--- a/src/cmd/internal/obj/sizeof_test.go
+++ b/src/cmd/internal/obj/sizeof_test.go
@@ -21,7 +21,7 @@ func TestSizeof(t *testing.T) {
                _64bit uintptr     // size on 64bit platforms
        }{
                {Addr{}, 32, 48},
-               //{LSym{}, 56, 104}, // TODO: re-enable
+               {LSym{}, 76, 128},
                {Prog{}, 132, 200},
        }
 

diff --git a/test/linkx.go b/test/linkx.go
index 2b5b6edd47a65e9044be38f63d89a6b3f7ac0369..4f85b241a96d586ffe646e9bd53d4a3bc4213e80 100644 (file)
--- a/test/linkx.go
+++ b/test/linkx.go
@@ -32,8 +32,6 @@ func main() {
 
        // Check non-string symbols are not overwritten.
        // This also make them used.
-       // TODO: decide if we need to issue an error if -X
-       // is applied to a non-string unreachable symbol.
        if b || x != 0 {
                panic("b or x overwritten")
        }