]> Cypherpunks.ru repositories - gostls13.git/commitdiff
[dev.regabi] test: run abi/regabipragma test with -c=1
authorCherry Zhang <cherryyz@google.com>
Fri, 12 Feb 2021 00:55:07 +0000 (19:55 -0500)
committerCherry Zhang <cherryyz@google.com>
Tue, 16 Feb 2021 21:51:58 +0000 (21:51 +0000)
Currently, we call Warnl in SSA backend when we see a function
(defined or called) with regparams pragma. Calling Warnl in
concurrent environment is racy. As the debugging output is
temporary, for testing purposes we just pass -c=1. We'll remove
the pragma and the debugging print some time soon.

Change-Id: I6f925a665b953259453fc458490c5ff91f67c91a
Reviewed-on: https://go-review.googlesource.com/c/go/+/291710
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>

test/abi/regabipragma.go
test/run.go

index 6a1b1938ea038bf0bfa94b38bb64287b966db4b9..e7ecd58fc893701d41808af4616e577e7c71aba1 100644 (file)
@@ -1,4 +1,4 @@
-// runindir
+// runindir -gcflags=-c=1
 // +build !windows
 
 // Copyright 2021 The Go Authors. All rights reserved.
index 116f983a97a151562fc67392aea41e7c4e292356..dba4d16d63e6ed3cce2d64c7a04b69e610c0ab18 100644 (file)
@@ -902,6 +902,7 @@ func (t *test) run() {
                if *linkshared {
                        cmd = append(cmd, "-linkshared")
                }
+               cmd = append(cmd, flags...)
                cmd = append(cmd, ".")
                out, err := runcmd(cmd...)
                if err != nil {