cmd/compile/internal/types2: remove "unimplemented" function (cleanup)

Change-Id: I72fed206df1a4e36d5e519378599e8d952423d53
Reviewed-on: https://go-review.googlesource.com/c/go/+/438346
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

diff --git a/src/cmd/compile/internal/types2/errors.go b/src/cmd/compile/internal/types2/errors.go
index 09d44f68994e1ce2ebbc156464774e4c36e62465..0906a1b45c2dfb0b9a8d3f907c7b2f16912be882 100644 (file)
--- a/src/cmd/compile/internal/types2/errors.go
+++ b/src/cmd/compile/internal/types2/errors.go
@@ -15,10 +15,6 @@ import (
        "strings"
 )
 
-func unimplemented() {
-       panic("unimplemented")
-}
-
 func assert(p bool) {
        if !p {
                msg := "assertion failed"

diff --git a/src/cmd/compile/internal/types2/expr.go b/src/cmd/compile/internal/types2/expr.go
index 7543431f8d309c6e667ae3317c02a34a20e24f5e..6abd9ca31103824e16d1e33a2f1c303a47be71a0 100644 (file)
--- a/src/cmd/compile/internal/types2/expr.go
+++ b/src/cmd/compile/internal/types2/expr.go
@@ -562,7 +562,7 @@ func (check *Checker) updateExprType0(parent, x syntax.Expr, typ Type, final boo
                                // see commented out code for StarExpr above
                                // TODO(gri) needs cleanup
                                if debug {
-                                       unimplemented()
+                                       panic("unimplemented")
                                }
                                return
                        }

diff --git a/src/cmd/compile/internal/types2/subst.go b/src/cmd/compile/internal/types2/subst.go
index d5a48c699561d02062e38ebc11d337635133131d..74d6294dff03f56e4d8f2d43159367ea7bb1dd16 100644 (file)
--- a/src/cmd/compile/internal/types2/subst.go
+++ b/src/cmd/compile/internal/types2/subst.go
@@ -6,7 +6,9 @@
 
 package types2
 
-import "cmd/compile/internal/syntax"
+import (
+       "cmd/compile/internal/syntax"
+)
 
 type substMap map[*TypeParam]Type
 
@@ -262,7 +264,7 @@ func (subst *subster) typ(typ Type) Type {
                return subst.smap.lookup(t)
 
        default:
-               unimplemented()
+               unreachable()
        }
 
        return typ

diff --git a/src/go/types/subst.go b/src/go/types/subst.go
index 42f3619f884f04500f7ad5172299c456a9d38ffb..5a49c0447f3b9c33036259338f4d9e3920f59a58 100644 (file)
--- a/src/go/types/subst.go
+++ b/src/go/types/subst.go
@@ -6,7 +6,9 @@
 
 package types
 
-import "go/token"
+import (
+       "go/token"
+)
 
 type substMap map[*TypeParam]Type
 
@@ -262,7 +264,7 @@ func (subst *subster) typ(typ Type) Type {
                return subst.smap.lookup(t)
 
        default:
-               panic("unimplemented")
+               unreachable()
        }
 
        return typ