]> Cypherpunks.ru repositories - gostls13.git/commitdiff
runtime: update skips for TestGdbBacktrace
authorMichael Pratt <mpratt@google.com>
Thu, 1 Jun 2023 16:34:20 +0000 (12:34 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 1 Jun 2023 19:44:26 +0000 (19:44 +0000)
One issue simply has a reworded message, probably from a new version of
GDB. Another is a new issue.

Fixes #60553.
Fixes #58698.
Updates #39204.

Change-Id: I8389aa981fab5421f57ee761bfb5e1dd237709ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/499975
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/runtime/runtime-gdb_test.go

index 1577d0995d8d4eeddf61d5ddfb90a47a97a2bb2f..19069f4462b0a9197cd5f25abe65a3f11cee6f73 100644 (file)
@@ -470,15 +470,17 @@ func TestGdbBacktrace(t *testing.T) {
        got, err := cmd.CombinedOutput()
        t.Logf("gdb output:\n%s", got)
        if err != nil {
-               if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) {
+               switch {
+               case bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")):
                        // GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28551
                        testenv.SkipFlaky(t, 43068)
-               }
-               if bytes.Contains(got, []byte("Couldn't get registers: No such process.")) {
+               case bytes.Contains(got, []byte("Couldn't get registers: No such process.")), bytes.Contains(got, []byte("Unable to fetch general registers.: No such process.")):
                        // GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9086
                        testenv.SkipFlaky(t, 50838)
-               }
-               if bytes.Contains(got, []byte(" exited normally]\n")) {
+               case bytes.Contains(got, []byte("waiting for new child: No child processes.")):
+                       // GDB bug: Sometimes it fails to wait for a clone child.
+                       testenv.SkipFlaky(t, 60553)
+               case bytes.Contains(got, []byte(" exited normally]\n")):
                        // GDB bug: Sometimes the inferior exits fine,
                        // but then GDB hangs.
                        testenv.SkipFlaky(t, 37405)