cmd/go/internal/work: set Incomplete to true if there is an error

Fixes #57724

Change-Id: I3d419985ff41d5ee93bb56d8c7ca5cd1d7231920
Reviewed-on: https://go-review.googlesource.com/c/go/+/536418
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go
index 4f4fb704b8b67b814efa38d910791113b7f3345f..ecad324886684bad26591809db9e4f5e75ec8d53 100644 (file)
--- a/src/cmd/go/internal/work/exec.go
+++ b/src/cmd/go/internal/work/exec.go
@@ -164,6 +164,7 @@ func (b *Builder) Do(ctx context.Context, root *Action) {
                        if b.AllowErrors && a.Package != nil {
                                if a.Package.Error == nil {
                                        a.Package.Error = &load.PackageError{Err: err}
+                                       a.Package.Incomplete = true
                                }
                        } else {
                                var ipe load.ImportPathError

diff --git a/src/cmd/go/testdata/script/list_export_e.txt b/src/cmd/go/testdata/script/list_export_e.txt
index 8e4c361fc4ede8ef11817335b365b231dfa0580f..6d5dd39f0bd476df497dfd1dafd2d675674e9412 100644 (file)
--- a/src/cmd/go/testdata/script/list_export_e.txt
+++ b/src/cmd/go/testdata/script/list_export_e.txt
@@ -6,6 +6,10 @@ go list -f '{{with .Error}}{{.}}{{end}}' -e -export ./...
 ! stderr '.'
 stdout '^# example.com/p2\np2'${/}'main\.go:7:.*'
 
+go list -export -e -f '{{.ImportPath}} -- {{.Incomplete}} -- {{.Error}}' ./...
+stdout 'example.com/p1 -- false -- <nil>'
+stdout 'example.com/p2 -- true -- # example.com/p2'
+
 go list -e -export -json=Error ./...
 stdout '"Err": "# example.com/p2'