cmd/compile: minor doc improvements

These are left over from comments I failed to leave on CL 249463;
apparently I never hit "Reply".

Change-Id: Ia3f8a900703c347f8f98581ec1ac172c0f72cd9e
Reviewed-on: https://go-review.googlesource.com/c/go/+/299589
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>

diff --git a/src/cmd/compile/internal/ssa/decompose.go b/src/cmd/compile/internal/ssa/decompose.go
index ea988e44f61a6ffe1a2cbfe195d2da09b0690db6..ba48b6b3b96503cbde026d790a341a5798c83040 100644 (file)
--- a/src/cmd/compile/internal/ssa/decompose.go
+++ b/src/cmd/compile/internal/ssa/decompose.go
@@ -24,7 +24,7 @@ func decomposeBuiltIn(f *Func) {
        }
 
        // Decompose other values
-       // Note: deadcode is false because we need to keep the original
+       // Note: Leave dead values because we need to keep the original
        // values around so the name component resolution below can still work.
        applyRewrite(f, rewriteBlockdec, rewriteValuedec, leaveDeadValues)
        if f.Config.RegSize == 4 {

diff --git a/src/cmd/compile/internal/ssa/rewrite.go b/src/cmd/compile/internal/ssa/rewrite.go
index 07bbdb8813b0d18a4a7b06075fd205c8ea27144c..5c56b2b346ada530a6b0e0d187716466dd253e61 100644 (file)
--- a/src/cmd/compile/internal/ssa/rewrite.go
+++ b/src/cmd/compile/internal/ssa/rewrite.go
@@ -27,7 +27,7 @@ const (
        removeDeadValues                 = true
 )
 
-// deadcode indicates that rewrite should try to remove any values that become dead.
+// deadcode indicates whether rewrite should try to remove any values that become dead.
 func applyRewrite(f *Func, rb blockRewriter, rv valueRewriter, deadcode deadValueChoice) {
        // repeat rewrites until we find no more rewrites
        pendingLines := f.cachedLineStarts // Holds statement boundaries that need to be moved to a new value/block

diff --git a/src/cmd/compile/internal/ssa/value.go b/src/cmd/compile/internal/ssa/value.go
index c20fc87e907c0529d625ca896dd9d226bbd8f039..6cc2b2ab8ba8cfe59d5b0eeb91b52fd78b0670b1 100644 (file)
--- a/src/cmd/compile/internal/ssa/value.go
+++ b/src/cmd/compile/internal/ssa/value.go
@@ -499,7 +499,7 @@ func (v *Value) removeable() bool {
                return false
        }
        if v.Type.IsMemory() {
-               // All memory ops aren't needed here, but we do need
+               // We don't need to preserve all memory ops, but we do need
                // to keep calls at least (because they might have
                // synchronization operations we can't see).
                return false