]> Cypherpunks.ru repositories - gostls13.git/commitdiff
sort: cut 140 seconds off race build tests
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 14 Sep 2016 18:14:34 +0000 (18:14 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 14 Sep 2016 19:06:32 +0000 (19:06 +0000)
No coverage is gained by running the 1e6 versions of the test over the
1e4 versions. It just adds 140 seconds of race overhead time.

Updates #17104

Change-Id: I41408aedae34a8b1a148eebdda20269cdefffba3
Reviewed-on: https://go-review.googlesource.com/29159
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/sort/sort_test.go

index 60fac2d695180aadaf2bd1624715bafa8d311f00..10a2c19684855a54f36ebeb805bc9be82e7441e8 100644 (file)
@@ -6,10 +6,12 @@ package sort_test
 
 import (
        "fmt"
+       "internal/testenv"
        "math"
        "math/rand"
        . "sort"
        "strconv"
+       stringspkg "strings"
        "testing"
 )
 
@@ -555,6 +557,9 @@ func TestCountStableOps(t *testing.T) { countOps(t, Stable, "Stable") }
 func TestCountSortOps(t *testing.T)   { countOps(t, Sort, "Sort  ") }
 
 func bench(b *testing.B, size int, algo func(Interface), name string) {
+       if stringspkg.HasSuffix(testenv.Builder(), "-race") && size > 1e4 {
+               b.Skip("skipping slow benchmark on race builder")
+       }
        b.StopTimer()
        data := make(intPairs, size)
        x := ^uint32(0)