]> Cypherpunks.ru repositories - gostls13.git/commitdiff
misc/cgo/testsanitizers: use buffered channel in tsan12.go
authorCherry Mui <cherryyz@google.com>
Tue, 24 May 2022 00:20:07 +0000 (20:20 -0400)
committerCherry Mui <cherryyz@google.com>
Tue, 24 May 2022 14:30:46 +0000 (14:30 +0000)
os/signal.Notify requires that "the caller must ensure that c has
sufficient buffer space to keep up with the expected signal rate"
as it does a nonblocking send when it receives a signal. The test
currently using a unbuffered channel, which means it may miss the
signal if the signal arrives before the channel receive operation.

Fixes #52998.

Change-Id: Icdcab9396d735506480ef880fb45a4669fa7cc8f
Reviewed-on: https://go-review.googlesource.com/c/go/+/407888
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

misc/cgo/testsanitizers/testdata/tsan12.go

index 3e767eee1f83e080d75d53d65082939809240cbe..0ef545d09b6f59581b58705ddf7d97c84891dd40 100644 (file)
@@ -22,7 +22,7 @@ import (
 import "C"
 
 func main() {
-       ch := make(chan os.Signal)
+       ch := make(chan os.Signal, 1)
        signal.Notify(ch, syscall.SIGUSR1)
 
        if err := exec.Command("true").Run(); err != nil {