]> Cypherpunks.ru repositories - gostls13.git/commitdiff
os: skip TestExecutableDeleted earlier when 'go build' is not supported
authorBryan C. Mills <bcmills@google.com>
Fri, 10 Mar 2023 19:21:01 +0000 (14:21 -0500)
committerGopher Robot <gobot@golang.org>
Fri, 10 Mar 2023 21:27:06 +0000 (21:27 +0000)
The test unconditionally calls testenv.GoToolPath, which will skip the
test anyway. Moving the skip earlier gets this test out of goroutine
dumps if the test process fails or times out, making it easier to
diagnose failures in the remaining tests.

Change-Id: Ibd39546708a83b6f15616b2c4ae7af420e2401f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/475455
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/os/executable_test.go

index 8d1794d3400e35c7d9ad003bc1f3746594bb60e1..c835bb436baa018ede9ce54b3bed7e5b21f95d83 100644 (file)
@@ -89,7 +89,7 @@ func init() {
 }
 
 func TestExecutableDeleted(t *testing.T) {
-       testenv.MustHaveExec(t)
+       testenv.MustHaveGoBuild(t)
        switch runtime.GOOS {
        case "windows", "plan9":
                t.Skipf("%v does not support deleting running binary", runtime.GOOS)