go/types: avoid declared but not used error for a couple of cases

The change in typexpr.go matches types2 behavior.

For #54511.

Change-Id: I79c922a94f2ee0440c1814140935c321439c7d25
Reviewed-on: https://go-review.googlesource.com/c/go/+/425714
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>

diff --git a/src/go/types/testdata/check/builtins0.go b/src/go/types/testdata/check/builtins0.go
index 936595b06baa03c3d59ddabefa36d39da4e36832..f4932a8309eef7807c12197f3f5c4eebb6870b21 100644 (file)
--- a/src/go/types/testdata/check/builtins0.go
+++ b/src/go/types/testdata/check/builtins0.go
@@ -482,7 +482,7 @@ func make1() {
 }
 
 func make2() {
-       f1 /* ERROR not used */ := func() (x []int) { return }
+       f1 := func() (x []int) { return }
        _ = make(f0 /* ERROR not a type */ ())
        _ = make(f1 /* ERROR not a type */ ())
 }
@@ -502,7 +502,7 @@ func new1() {
 }
 
 func new2() {
-       f1 /* ERROR not used */ := func() (x []int) { return }
+       f1 := func() (x []int) { return }
        _ = new(f0 /* ERROR not a type */ ())
        _ = new(f1 /* ERROR not a type */ ())
 }

diff --git a/src/go/types/typexpr.go b/src/go/types/typexpr.go
index 397bd75db336f3448188e3697f29b1037f632311..13adb9f2a982dd25ed80891289feca35cf1d19eb 100644 (file)
--- a/src/go/types/typexpr.go
+++ b/src/go/types/typexpr.go
@@ -377,6 +377,7 @@ func (check *Checker) typInternal(e0 ast.Expr, def *Named) (T Type) {
 
        default:
                check.errorf(e0, _NotAType, "%s is not a type", e0)
+               check.use(e0)
        }
 
        typ := Typ[Invalid]