]> Cypherpunks.ru repositories - gostls13.git/commitdiff
runtime: remove p padding field for atomic fields alignment
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 18 Aug 2022 15:53:19 +0000 (22:53 +0700)
committerGopher Robot <gobot@golang.org>
Thu, 18 Aug 2022 18:18:45 +0000 (18:18 +0000)
CL 424396 and CL 424397 changed timer0When/timerModifiedEarliest to
atomic.Uint64, just they're guaranted to have 64-bit alignment.

Change-Id: Idaff1059da2aac84520b9b0e34f9721a74dbba5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/424794
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/runtime/align_runtime_test.go
src/runtime/runtime2.go

index 2c448d4a0904fc4ecfb399930efc435f229d6947..3a6a575481b243cd9a84dcf471b667614df9c83e 100644 (file)
@@ -14,8 +14,6 @@ import "unsafe"
 // operations (all the *64 operations in runtime/internal/atomic).
 var AtomicFields = []uintptr{
        unsafe.Offsetof(m{}.procid),
-       unsafe.Offsetof(p{}.timer0When),
-       unsafe.Offsetof(p{}.timerModifiedEarliest),
        unsafe.Offsetof(p{}.gcFractionalMarkTime),
        unsafe.Offsetof(profBuf{}.overflow),
        unsafe.Offsetof(profBuf{}.overflowTime),
index 56318e2bce7cf9072fe8e0db448fa212cf411e0e..5e12ac73bc918f9ea2325cef065905ab0129a9f3 100644 (file)
@@ -667,8 +667,6 @@ type p struct {
 
        palloc persistentAlloc // per-P to avoid mutex
 
-       _ uint32 // Alignment for atomic fields below
-
        // The when field of the first entry on the timer heap.
        // This is 0 if the timer heap is empty.
        timer0When atomic.Int64