]> Cypherpunks.ru repositories - gostls13.git/commitdiff
all: check GOROOT_BOOTSTRAP executable before bootsrappping
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 10 Sep 2020 06:21:41 +0000 (13:21 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 10 Sep 2020 12:11:16 +0000 (12:11 +0000)
Otherwise we’d still be writing that we're building cmd/dist
even if GOROOT_BOOTSTRAP we’re wrongly set.

Change-Id: I940e18c3cebae5664f85babc9919e9eb215d5093
Reviewed-on: https://go-review.googlesource.com/c/go/+/253877
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
src/make.bash

index 880a0f43d59675098c2e274bec92cd56e9dc6ee5..3a84658c72deabcc2db0435ef09471dc6562060b 100755 (executable)
@@ -162,16 +162,16 @@ IFS=$'\n'; for go_exe in $(type -ap go); do
                fi
        fi
 done; unset IFS
-GOROOT_BOOTSTRAP_VERSION=$($GOROOT_BOOTSTRAP/bin/go version | sed 's/go version //')
-echo "Building Go cmd/dist using $GOROOT_BOOTSTRAP. ($GOROOT_BOOTSTRAP_VERSION)"
-if $verbose; then
-       echo cmd/dist
-fi
 if [ ! -x "$GOROOT_BOOTSTRAP/bin/go" ]; then
        echo "ERROR: Cannot find $GOROOT_BOOTSTRAP/bin/go." >&2
        echo "Set \$GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4." >&2
        exit 1
 fi
+GOROOT_BOOTSTRAP_VERSION=$($GOROOT_BOOTSTRAP/bin/go version | sed 's/go version //')
+echo "Building Go cmd/dist using $GOROOT_BOOTSTRAP. ($GOROOT_BOOTSTRAP_VERSION)"
+if $verbose; then
+       echo cmd/dist
+fi
 if [ "$GOROOT_BOOTSTRAP" = "$GOROOT" ]; then
        echo "ERROR: \$GOROOT_BOOTSTRAP must not be set to \$GOROOT" >&2
        echo "Set \$GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4." >&2