]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.typeparams] cmd/compile: skip types2 GC test during bootstrapping
authorMatthew Dempsky <mdempsky@google.com>
Thu, 17 Jun 2021 22:36:23 +0000 (15:36 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 17 Jun 2021 23:14:04 +0000 (23:14 +0000)
commitfeec53c4e5641f6a9f89ba9dcd8d89d84ea2717c
tree0366510831159a9164c660c579a88d83f62b1c31
parentfb84d213a8551526913647b7dea6103233f550db
[dev.typeparams] cmd/compile: skip types2 GC test during bootstrapping

Unified includes a check to make sure that types2 memory has been
garbage collected, but it relies on precise finalization, which we
provide (for dynamically allocated objects, at least) but isn't
guaranteed by the Go spec. In particular, Go 1.4 doesn't provide this.

The check is strictly unnecessary and only exists to make sure we
don't regress and start holding onto types2 memory accidentally. So
just disable the check during bootstrap builds.

Change-Id: Ie54fe53b2edba02c0b0b1e5ae39d81be8a0ace8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/329269
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/base/bootstrap_false.go [new file with mode: 0644]
src/cmd/compile/internal/base/bootstrap_true.go [new file with mode: 0644]
src/cmd/compile/internal/noder/unified.go