]> Cypherpunks.ru repositories - gostls13.git/commit
net/http: log Readdir error to Server.ErrorLog
authorDmitri Shuralyov <shurcooL@gmail.com>
Tue, 8 Aug 2017 19:38:21 +0000 (15:38 -0400)
committerDmitri Shuralyov <shurcool@gmail.com>
Wed, 9 Aug 2017 17:51:42 +0000 (17:51 +0000)
commitf776b9d5fa3577fe2fdaa3d2ef9d48adee329f9c
tree6f915e1d8664c0915705cb55e0d9873892ddc2ac
parent3e7abf82e3e0614f7d8163053d944dc59d8b9247
net/http: log Readdir error to Server.ErrorLog

Now that issue #12438 is resolved, this TODO can be completed.
Create a logf helper, which is similar to Server.logf method,
but takes a *Request to infer the *Server and its ErrorLog from.

Update documentation of Server.ErrorLog to mention a new type
of errors that may be logged to it.

Also update a statement in documentation of Server.ErrorLog from:

// If nil, logging goes to os.Stderr via the log package's
// standard logger.

To:

// If nil, logging is done via the log package's standard logger.

The motivation for doing so is to avoid making inaccurate claims.
Logging may not go to os.Stderr if anyone overrides the log package's
default output via https://godoc.org/log#SetOutput. Saying that
the standard logger is used should be sufficient to explain the
behavior, and users can infer that os.Stderr is used by default,
unless it's changed.

Updates #12438.

Change-Id: I3a4b0db51d652fd25fb2065fbc2157a3dec4dd38
Reviewed-on: https://go-review.googlesource.com/53950
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/fs.go
src/net/http/server.go