]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.20] go/scanner: reject large line and column numbers in //line...
authorDamien Neil <dneil@google.com>
Wed, 22 Mar 2023 16:33:22 +0000 (09:33 -0700)
committerGopher Robot <gobot@golang.org>
Tue, 4 Apr 2023 16:59:15 +0000 (16:59 +0000)
commite7c4b07ecf6b367f1afc9cc48cde963829dd0aab
treeca0630322d020515e0fa1777532cd8941d8ca4eb
parentbf8c7c575c8a552d9d79deb29e80854dc88528d0
[release-branch.go1.20] go/scanner: reject large line and column numbers in //line directives

Setting a large line or column number using a //line directive can cause
integer overflow even in small source files.

Limit line and column numbers in //line directives to 2^30-1, which
is small enough to avoid int32 overflow on all reasonbly-sized files.

Fixes CVE-2023-24537
For #59180
Fixes #59274

Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1802456
Reviewed-by: Julie Qiu <julieqiu@google.com>
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Change-Id: Ib9c5cb38428ed34ab129d451b00a2998e72c861c
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1802401
TryBot-Result: Security TryBots <security-trybots@go-security-trybots.iam.gserviceaccount.com>
Run-TryBot: Roland Shoemaker <bracewell@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/481992
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Bypass: Michael Knyszek <mknyszek@google.com>
src/go/parser/parser_test.go
src/go/scanner/scanner.go