]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: simplify assert{E,I}2I{,2} calling conventions
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Wed, 17 Feb 2021 08:14:21 +0000 (15:14 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Tue, 23 Feb 2021 06:01:29 +0000 (06:01 +0000)
commite52149822b54811cedaaa87013de3fa4bc634e95
tree34bdc306bf2c00c662add4a459ea5dcff0e4d670
parent86deb459de6a309503aa445a7d686bd139354e5e
cmd/compile: simplify assert{E,I}2I{,2} calling conventions

This CL rebases CL 273694 on top of master with @mdempsky's permission.

For assertE2I and assertI2I, there's no need to pass through the
interface's data pointer: it's always going to come back unmodified.

For assertE2I2 and assertI2I2, there's no need for an extra bool
result parameter: it's redundant with testing the returned interface
value for nil.

Change-Id: Ic92d4409ad381952f875d3d74b8cf11c32702fa6
Reviewed-on: https://go-review.googlesource.com/c/go/+/292892
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/ssagen/ssa.go
src/cmd/compile/internal/typecheck/builtin.go
src/cmd/compile/internal/typecheck/builtin/runtime.go
src/runtime/iface.go
src/runtime/mfinal.go