]> Cypherpunks.ru repositories - gostls13.git/commit
runtime: never call into race detector with retaken P
authorNikhil Benesch <nikhil.benesch@gmail.com>
Fri, 9 Nov 2018 05:55:13 +0000 (00:55 -0500)
committerDmitry Vyukov <dvyukov@google.com>
Fri, 9 Nov 2018 21:47:48 +0000 (21:47 +0000)
commite496e612b7f45a09209f8f4e1c7c1d0db378dc18
tree08815019a1643110636dbd9beb23c78fc27d104a
parent06be7cbf3c27168172f1f89dd4f55cb07a37ec38
runtime: never call into race detector with retaken P

cgocall could previously invoke the race detector on an M whose P had
been retaken. The race detector would attempt to use the P-local state
from this stale P, racing with the thread that was actually wired to
that P. The result was memory corruption of ThreadSanitizer's internal
data structures that presented as hard-to-understand assertion failures
and segfaults.

Reorder cgocall so that it always acquires a P before invoking the race
detector, and add a test that stresses the interaction between cgo and
the race detector to protect against future bugs of this kind.

Fixes #27660.

Change-Id: Ide93f96a23490314d6647547140e0a412a97f0d4
Reviewed-on: https://go-review.googlesource.com/c/148717
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
misc/cgo/test/cgo_test.go
misc/cgo/test/test27660.go [new file with mode: 0644]
src/runtime/cgocall.go