]> Cypherpunks.ru repositories - gostls13.git/commit
syscall: remove wasip1 O_DIRECTORY workaround
authorAchille Roussel <achille.roussel@gmail.com>
Thu, 27 Apr 2023 21:37:55 +0000 (14:37 -0700)
committerGopher Robot <gobot@golang.org>
Fri, 28 Apr 2023 01:27:53 +0000 (01:27 +0000)
commitda3a184b182d5d0b18fd139df9e4259df4378095
tree7236ca75a158e03c6dcd0073df2965f62dd99a89
parentafe2d2221969c4c7082afdd4791dd8f2540fc684
syscall: remove wasip1 O_DIRECTORY workaround

Wasmtime used to error when opening a directory without passing the
O_DIRECTORY flag, which required doing a stat to determine whether to
inject the flag prior to opening any file.

The workaround was subject to races since the stat and open calls were
not atomic.

Wasmtime fixed the issue in v8.0.1.

For details see:
- https://github.com/bytecodealliance/wasmtime/pull/4967
- https://github.com/bytecodealliance/wasmtime/pull/6163
- https://github.com/bytecodealliance/wasmtime/releases/tag/v8.0.1

Change-Id: I0f9fe6a696024b70fffe63b83e8f61e48acd0c4a
Reviewed-on: https://go-review.googlesource.com/c/go/+/489955
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/syscall/fs_wasip1.go