]> Cypherpunks.ru repositories - gostls13.git/commit
crypto/x509: ignore Common Name by default
authorFilippo Valsorda <filippo@golang.org>
Fri, 1 May 2020 00:43:59 +0000 (20:43 -0400)
committerFilippo Valsorda <filippo@golang.org>
Fri, 8 May 2020 00:05:27 +0000 (00:05 +0000)
commitd65e1b2e41deb810565c94555d791e7384618da0
treee5c659717251d46023106eab7ff022e36ecf8544
parent9d1e120c421440b450e87cc6ac8900658f9bf01a
crypto/x509: ignore Common Name by default

Common Name has been deprecated for 20 years, and has horrible
interactions with Name Constraints. The browsers managed to drop it last
year, let's try flicking the switch to disabled by default.

Return helpful errors for things that would get unbroken by flipping the
switch back with the environment variable.

Had to refresh a test certificate that was too old to have SANs.

Updates #24151

Change-Id: I2ab78577fd936ba67969d3417284dbe46e4ae02f
Reviewed-on: https://go-review.googlesource.com/c/go/+/231379
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
src/crypto/x509/verify.go
src/crypto/x509/verify_test.go
src/crypto/x509/x509_test.go