]> Cypherpunks.ru repositories - gostls13.git/commit
go/types, types2: remove redundant calls to Named.resolve
authorRobert Findley <rfindley@google.com>
Sat, 7 May 2022 19:50:05 +0000 (15:50 -0400)
committerRobert Findley <rfindley@google.com>
Tue, 24 May 2022 17:47:42 +0000 (17:47 +0000)
commitd5ae7a64876630ab40f7bd04fdb5ad6a3733dae7
tree9e297ce25d9b13007d3b031a35c676b6084e82ae
parent7ce38641564e5c0183bb09df8c523caf5e0ab8e1
go/types, types2: remove redundant calls to Named.resolve

The resolved status of a Named type should be owned by its API, and
callers should access resolved data via methods. Remove several
instances where Named.resolve is explicitly invoked, only to be followed
by a method that also resolves.

Also make two minor cleanups:
- Remove the tparams parameter to Checker.newNamed, as it was unused.
- Include position information when assertions fail, so that one doesn't
  need to go digging in the panicking stack to find the assertion
  location.

Updates #52728

Change-Id: Icbe8c89e9cfe02d60af7d9ba907eaebe1f00193e
Reviewed-on: https://go-review.googlesource.com/c/go/+/404874
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
16 files changed:
src/cmd/compile/internal/types2/decl.go
src/cmd/compile/internal/types2/errors.go
src/cmd/compile/internal/types2/instantiate.go
src/cmd/compile/internal/types2/lookup.go
src/cmd/compile/internal/types2/named.go
src/cmd/compile/internal/types2/signature.go
src/cmd/compile/internal/types2/subst.go
src/cmd/compile/internal/types2/typexpr.go
src/go/types/decl.go
src/go/types/errors.go
src/go/types/instantiate.go
src/go/types/lookup.go
src/go/types/named.go
src/go/types/signature.go
src/go/types/subst.go
src/go/types/typexpr.go