]> Cypherpunks.ru repositories - gostls13.git/commit
log/slog: don't panic on aliased Record
authorJonathan Amsterdam <jba@google.com>
Fri, 28 Jul 2023 14:35:10 +0000 (10:35 -0400)
committerJonathan Amsterdam <jba@google.com>
Mon, 7 Aug 2023 15:10:55 +0000 (15:10 +0000)
commitcf39736f87613195aa8a2d7304ee20d7d9eeaa47
treedeb5b0a6e09993bdd8020d54a568343cc30343a0
parent8a6acecfab2879ba4e26487c99f204ede8b3d935
log/slog: don't panic on aliased Record

If the shared slice in a copied is modified, make a copy of it
and insert an attribute that warns of the bug.

Previously, we panicked, and panics in logging code should be avoided.

Change-Id: I24e9b0bf5c8cd09cf733e7dae8a82d025ef214e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/513760
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/log/slog/record.go
src/log/slog/record_test.go