]> Cypherpunks.ru repositories - gostls13.git/commit
test: make nosplit test invariant to ABI wrappers
authorAustin Clements <austin@google.com>
Wed, 17 Mar 2021 22:28:38 +0000 (18:28 -0400)
committerAustin Clements <austin@google.com>
Thu, 18 Mar 2021 16:51:25 +0000 (16:51 +0000)
commitc71acbfe8372099877cdc989b546389b05222600
tree72497d12a5256ee0a83b5fd9fa4e87911f8d9182
parentaf4388aee195c4328a779ba8f8171ad1632feb7e
test: make nosplit test invariant to ABI wrappers

Currently, the nosplit test disables ABI wrapper generation because it
generates a main.main in assembly, and so the ABI wrapper for calling
from runtime.main to main.main counts against the nosplit limit, which
cases some of the tests to fail.

Fix this by first entering ABI0 in a splittable context and then
calling from there into the test entry point, since this doesn't
introduce an ABI wrapper.

While we're here, this CL removes the test's check for the
framepointer experiment. That's now statically enabled, so it doesn't
appear in the experiment line, and enabling any other experiment
causes the test to think that the framepointer experiment *isn't*
enabled.

For #40724.

Change-Id: I6291eb9391f129779e726c5fc8c41b7b4a14eeb9
Reviewed-on: https://go-review.googlesource.com/c/go/+/302772
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
test/nosplit.go