]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.22] cmd/trace/v2,internal/trace: use correct frame for identifyin...
authorNick Ripley <nick.ripley@datadoghq.com>
Wed, 7 Feb 2024 16:43:05 +0000 (11:43 -0500)
committerCarlos Amedee <carlos@golang.org>
Tue, 27 Feb 2024 21:52:04 +0000 (21:52 +0000)
commitc33adf44ffc96c60cca8a7e877b8748abe4664f5
tree0058cdec1db5676f09c72d8f0f79620cf3597f4d
parent3b719980785f8e055392ec9fddd54212a0c0b257
[release-branch.go1.22] cmd/trace/v2,internal/trace: use correct frame for identifying goroutines

To determine the identity of a goroutine for displaying in the trace UI,
we should use the root frame from a call stack. This will be the
starting function for the goroutine and is the same for each call stack
from a given goroutine. The new tracer no longer includes starting PCs
for goroutines which existed at the start of tracing, so we can't use a
PC for grouping together goroutines any more. Instead, we just use the
name of the entry function for grouping.

For #65574
Fixes #65577

Change-Id: I5324653316f1acf0ab90c30680f181060ea45dd7
Reviewed-on: https://go-review.googlesource.com/c/go/+/562455
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit a51713103b5769a792b691e313254b7806855fa6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/562558
Reviewed-by: Michael Pratt <mpratt@google.com>
src/cmd/trace/v2/goroutines.go
src/cmd/trace/v2/pprof.go
src/internal/trace/summary.go
src/internal/trace/summary_test.go