]> Cypherpunks.ru repositories - gostls13.git/commit
Revert "go/printer: forbid empty line before first comment in block"
authorJoe Tsai <thebrokentoaster@gmail.com>
Fri, 1 Dec 2017 00:59:45 +0000 (00:59 +0000)
committerJoe Tsai <joetsai@google.com>
Fri, 1 Dec 2017 01:12:26 +0000 (01:12 +0000)
commitb53088a63436ac49d2344a733a50d529b5f7244e
tree9aeacef6839fd1e6c8ad28be2b3cb45756f6a19f
parent206568566473e9a91c05b8b0153d27ecbee466b7
Revert "go/printer: forbid empty line before first comment in block"

This reverts commit 08f19bbde1b01227fdc2fa2d326e4029bb74dd96.

Reason for revert:
The changed transformation takes effect on a larger set
of code snippets than expected.

For example, this:
    func foo() {

        // Comment
        bar()

    }
becomes:
    func foo() {
        // Comment
        bar()

    }

This is an unintended consequence.

Change-Id: Ifca88d6267dab8a8170791f7205124712bf8ace8
Reviewed-on: https://go-review.googlesource.com/81335
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Joe Tsai <joetsai@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
30 files changed:
misc/cgo/test/buildid_linux.go
src/cmd/compile/internal/ssa/gen/rulegen.go
src/cmd/internal/obj/ppc64/asm9.go
src/cmd/internal/obj/x86/asm6.go
src/cmd/link/internal/ld/data.go
src/cmd/link/internal/ppc64/asm.go
src/encoding/base32/base32.go
src/go/doc/testdata/blank.0.golden
src/go/doc/testdata/blank.2.golden
src/go/doc/testdata/testing.0.golden
src/go/doc/testdata/testing.2.golden
src/go/printer/nodes.go
src/go/printer/printer.go
src/go/printer/testdata/comments.golden
src/go/printer/testdata/comments.input
src/go/printer/testdata/comments.x
src/hash/crc32/crc32_ppc64le.go
src/image/internal/imageutil/impl.go
src/net/http/httputil/dump_test.go
src/net/http/httputil/persist.go
src/net/http/internal/chunked.go
src/net/http/requestwrite_test.go
src/net/http/server.go
src/net/mail/message_test.go
src/regexp/syntax/parse.go
src/runtime/symtab.go
src/syscall/syscall_netbsd.go
src/syscall/syscall_openbsd.go
src/time/sleep_test.go
src/unicode/example_test.go