]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.21] cmd/compile: fix escape analysis of string min/max
authorMatthew Dempsky <mdempsky@google.com>
Tue, 5 Dec 2023 20:56:04 +0000 (12:56 -0800)
committerCarlos Amedee <carlos@golang.org>
Wed, 6 Dec 2023 21:31:12 +0000 (21:31 +0000)
commit9f8b3ac8c4ce3023f27fae230d04507a43cb80c4
tree45dd955449fd27b6eb65620734c090db26edfa46
parent8c840b10d0c34091349fc224756924fea9c54c9b
[release-branch.go1.21] cmd/compile: fix escape analysis of string min/max

When I was plumbing min/max support through the compiler, I was
thinking mostly about numeric argument types. As a result, I forgot
that escape analysis would need to be aware that min/max can operate
on string values, which contain pointers.

Updates #64565.
Fixes #64567.

Change-Id: I36127ce5a2da942401910fa0f9de922726c9f94d
Reviewed-on: https://go-review.googlesource.com/c/go/+/547715
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 34416d7f6f93cd6562636e311c362ebe421f1a4c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/547757
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/escape/call.go
test/escape_calls.go
test/fixedbugs/issue64565.go [new file with mode: 0644]
test/fixedbugs/issue64565.out [new file with mode: 0644]