]> Cypherpunks.ru repositories - gostls13.git/commit
all: use a hermetic "go" tool in standard-library tests
authorBryan C. Mills <bcmills@google.com>
Thu, 21 May 2020 18:16:50 +0000 (14:16 -0400)
committerBryan C. Mills <bcmills@google.com>
Thu, 21 May 2020 21:17:48 +0000 (21:17 +0000)
commit9f4aeb36e22f5c7eda76111b4c49c0434b4d2897
treeefff143de18ada2b60dc8bd0a09c48906b380dd0
parent11b3730a02c93fd5745bfd977156541a9033759b
all: use a hermetic "go" tool in standard-library tests

The go/build package uses the "go" tool from the user's environment,
but its tests should not assume that that tool is in any particular
state, let alone appropriate for running the test.

Instead, explicitly use testenv.GoTool, adding it to $PATH in a
TestMain when necessary.

Fixes #39199
Fixes #39198

Change-Id: I56618a55ced473e75dd96eeb3a8f7084e2e64d02
Reviewed-on: https://go-review.googlesource.com/c/go/+/234880
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
src/go/build/build_test.go
src/go/internal/srcimporter/srcimporter_test.go
src/text/template/link_test.go