]> Cypherpunks.ru repositories - gostls13.git/commit
time: revert strict parsing of RFC 3339
authorJoe Tsai <joetsai@digital-static.net>
Wed, 18 Jan 2023 18:22:54 +0000 (10:22 -0800)
committerGopher Robot <gobot@golang.org>
Wed, 18 Jan 2023 19:59:26 +0000 (19:59 +0000)
commit9894ded19417fbc40420dc813d3c6606348ad31b
treec2f0821ed75854e62494cd27157f1543ac5abf89
parent6fcbd0369d3ac9002e2b46229f90ce64ce0539e4
time: revert strict parsing of RFC 3339

CL 444277 fixed Time.UnmarshalText and Time.UnmarshalJSON to properly
unmarshal timestamps according to RFC 3339 instead of according
to Go's bespoke time syntax that is a superset of RFC 3339.

However, this change seems to have broken an AWS S3 unit test
that relies on parsing timestamps with single digit hours.
It is unclear whether S3 emits these timestamps in production or
whether this is simply a testing artifact that has been cargo culted
across many code bases. Either way, disable strict parsing for now
and re-enable later with better GODEBUG support.

Updates #54580

Change-Id: Icced2c7f9a6b2fc06bbd9c7e90f90edce24c2306
Reviewed-on: https://go-review.googlesource.com/c/go/+/462286
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Joseph Tsai <joetsai@digital-static.net>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
doc/go1.20.html
src/time/format_rfc3339.go
src/time/time_test.go