]> Cypherpunks.ru repositories - gostls13.git/commit
test: re-enable most go/tests that were disabled because of types2 differences
authorDan Scales <danscales@google.com>
Sat, 4 Dec 2021 00:10:10 +0000 (16:10 -0800)
committerDan Scales <danscales@google.com>
Tue, 11 Jan 2022 02:26:58 +0000 (02:26 +0000)
commit90a8482a176b8cf47e8b24a3459f0a24e038f675
tree0b0f6bf62ea5eb5e1a619ad6011c39709919fea9
parent4ceb5a94d83b823fe7c3e4d25541854759651933
test: re-enable most go/tests that were disabled because of types2 differences

I made the default be that, where there are differences between types2
and -G=0 error messages, we want errorcheck tests to pass types2.
Typically, we can get errorcheck to pass on types2 and -G=0 if they give
the same number of error messages on the same lines, just different
wording. If they give a different number of error messages, then I made
types2 pass. I added an exception list for -G=0 to cover those cases
where -G=0 and types give different numbers of error messages.

Because types2 does not run if there are syntax errors, for several
tests, I had to split the tests into two parts in order to get all the
indicated errors to be reported in types2 (bug228.go, bug388.go,
issue11610.go, issue14520.go)

I tried to preserve the GCCGO labeling correctly (but may have gotten
some wrong). When types2 now matches where a GCCGO error previously
occurred, I transformed GCCGO_ERROR -> ERROR. When types2 no longer
reports an error in a certain place, I transformed ERROR -> GCCGO_ERROR.
When types2 reports an error in a new place, I used GC_ERROR.

The remaining entries in types2Failures are things that I think we
probably still need to fix - either actually missing errors in types2,
or cases where types2 gives worse errors than -G=0.

Change-Id: I7f01e82b322b16094096b67d7ed2bb39b410c34f
Reviewed-on: https://go-review.googlesource.com/c/go/+/372854
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
37 files changed:
test/fixedbugs/bug176.go
test/fixedbugs/bug195.go
test/fixedbugs/bug228.go
test/fixedbugs/bug228a.go [new file with mode: 0644]
test/fixedbugs/bug231.go
test/fixedbugs/bug255.go
test/fixedbugs/bug388.go
test/fixedbugs/bug388a.go [new file with mode: 0644]
test/fixedbugs/bug412.go
test/fixedbugs/issue11590.go
test/fixedbugs/issue11610.go
test/fixedbugs/issue11610a.go [new file with mode: 0644]
test/fixedbugs/issue11614.go
test/fixedbugs/issue14520.go
test/fixedbugs/issue14520a.go [new file with mode: 0644]
test/fixedbugs/issue17038.go
test/fixedbugs/issue19012.go
test/fixedbugs/issue21979.go
test/fixedbugs/issue23732.go
test/fixedbugs/issue25958.go
test/fixedbugs/issue28079b.go
test/fixedbugs/issue28268.go
test/fixedbugs/issue33460.go
test/fixedbugs/issue4232.go
test/fixedbugs/issue4452.go
test/fixedbugs/issue4510.dir/f1.go
test/fixedbugs/issue4510.dir/f2.go
test/fixedbugs/issue7525.go
test/fixedbugs/issue7525b.go
test/fixedbugs/issue7525c.go
test/fixedbugs/issue7525d.go
test/fixedbugs/issue7525e.go
test/import1.go
test/import6.go
test/initializerr.go
test/run.go
test/typecheck.go