]> Cypherpunks.ru repositories - gostls13.git/commit
runtime: skip TestRuntimeLockMetricsAndProfile for flakiness
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 18 Dec 2023 17:03:19 +0000 (17:03 +0000)
committerGopher Robot <gobot@golang.org>
Mon, 18 Dec 2023 17:42:38 +0000 (17:42 +0000)
commit8e3930f2588a3f6d8fcaac7ef8add9c2d5dedc0e
tree6c32f399268b5a299105b1c08c97b8d2622a72e8
parent9b4b3e5acca2dabe107fa2c3ed963097d78a4562
runtime: skip TestRuntimeLockMetricsAndProfile for flakiness

This test was added to check new mutex profile functionality.
Specifically, it checks to make sure that the functionality behind
GODEBUG=runtimecontentionstacks works. The runtime currently tracks
contention from runtime-internal mutexes in mutex profiles, but it does
not record stack traces for them, attributing the time to a dummy
symbol. This GODEBUG enables collecting stacks.

Just disable the test. Even if this functionality breaks, it won't
affect Go users and it'll help keep the builders green. It's fine to
leave the test because this will be revisited in the next dev cycle.

For #64253.

Change-Id: I7938fe0f036fc4e4a0764f030e691e312ec2c9b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/550775
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Eli Bendersky <eliben@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
src/runtime/metrics_test.go