]> Cypherpunks.ru repositories - gostls13.git/commit
runtime: remove g.gcscanvalid
authorAustin Clements <austin@google.com>
Fri, 27 Sep 2019 18:13:22 +0000 (14:13 -0400)
committerAustin Clements <austin@google.com>
Fri, 25 Oct 2019 23:25:32 +0000 (23:25 +0000)
commit8c5861576a983684faac98c612c9c7e569974ffa
treeacaca58d2264cf3079b8ff561809dd1a31a2858c
parent1b79afe460c329c1db75456c3278600a4b451b41
runtime: remove g.gcscanvalid

Currently, gcscanvalid is used to resolve a race between attempts to
scan a stack. Now that there's a clear owner of the stack scan
operation, there's no longer any danger of racing or attempting to
scan a stack more than once, so this CL eliminates gcscanvalid.

I double-checked my reasoning by first adding a throw if gcscanvalid
was set in scanstack and verifying that all.bash still passed.

For #10958, #24543.
Fixes #24363.

Change-Id: I76794a5fcda325ed7cfc2b545e2a839b8b3bc713
Reviewed-on: https://go-review.googlesource.com/c/go/+/201139
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/runtime/mgc.go
src/runtime/mgcmark.go
src/runtime/proc.go
src/runtime/runtime2.go
src/runtime/sizeof_test.go