]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: use a boolean as a avoid clobbering flags mov marker
authorJakub Ciolek <jakub@ciolek.dev>
Tue, 10 Jan 2023 07:36:00 +0000 (08:36 +0100)
committerKeith Randall <khr@golang.org>
Fri, 20 Jan 2023 05:01:15 +0000 (05:01 +0000)
commit8354f6b5bb5baf03cb64dbf736c276f297ebea96
tree31c0363fcb2016de05805715bda1cd91d6ef25c6
parent3e77efc7204407c5c8882bec42fdcaa88ef40a9b
cmd/compile: use a boolean as a avoid clobbering flags mov marker

The Value type implements Aux interface because it is being used as a
"avoid clobbering flags" marker by amd64, x86 and s390x SSA parts.

Create a boolean that implements the Aux interface. Use it as the marker
instead. We no longer need Value to implement Aux.

Resolves a TODO.

See CL 275756 for more info.

Change-Id: I8a1eddf7e738b8aa31e82f3c4c590bafd2cdc56b
Reviewed-on: https://go-review.googlesource.com/c/go/+/461156
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Jakub Ciolek <jakub@ciolek.dev>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/compile/internal/amd64/ssa.go
src/cmd/compile/internal/s390x/ssa.go
src/cmd/compile/internal/ssa/rewrite.go
src/cmd/compile/internal/ssa/value.go
src/cmd/compile/internal/x86/ssa.go