]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile/types2, go/types: add position for "have" in failed interface satisfaction
authorEmmanuel T Odeke <emmanuel@orijtech.com>
Tue, 11 Jan 2022 07:04:22 +0000 (23:04 -0800)
committerRobert Griesemer <gri@golang.org>
Wed, 12 Jan 2022 00:01:48 +0000 (00:01 +0000)
commit8070e70d64c5f82f1cf4c2079d97766e5da9775e
treec35a06f5d06375b4382ad509d93d5b77b57a8f47
parent1ee70da3125cb6339c1bcb0c127cd97a9e1dbe90
cmd/compile/types2, go/types: add position for "have" in failed interface satisfaction

With this change, we shall now see:

    *myS does not implement S (wrong type for DoSomething method)
        have DoSomething() (string, error) at ./main.go:9:14
want DoSomething() (int, error)

instead of previously:

    *myS does not implement S (wrong type for DoSomething method)
        have DoSomething() (string, error)
want DoSomething() (int, error)

Fixes #42841
Fixes #45813

Change-Id: I66990929e39b0d36f2e91da0d92f60586a9b84e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/373634
Trust: Robert Findley <rfindley@google.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/types2/lookup.go
src/cmd/compile/internal/types2/testdata/check/issues.src
src/go/types/lookup.go
test/fixedbugs/issue48471.go