]> Cypherpunks.ru repositories - gostls13.git/commit
go/types, types2: delay receiver type validation
authorRobert Griesemer <gri@golang.org>
Thu, 24 Feb 2022 21:35:16 +0000 (13:35 -0800)
committerRobert Griesemer <gri@golang.org>
Fri, 25 Feb 2022 15:55:34 +0000 (15:55 +0000)
commit7c694fbad1ed6f2f825fd09cf7a86da3be549cea
tree55fdd7596cda27420d51bd77f5853744f5964fa0
parent55e5b03cb359c591a2ca6ad8b6e9274d094b1632
go/types, types2: delay receiver type validation

Delay validation of receiver type as it may cause premature expansion
of types the receiver type is dependent on. This was actually a TODO.

While the diff looks large-ish, the actual change is small: all the
receiver validation code has been moved inside the delayed function
body, and a couple of comments have been adjusted.

Fixes #51232.
Fixes #51233.

Change-Id: I44edf0ba615996266791724b832d81b9ccb8b435
Reviewed-on: https://go-review.googlesource.com/c/go/+/387918
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/types2/signature.go
src/cmd/compile/internal/types2/testdata/fixedbugs/issue51232.go2 [new file with mode: 0644]
src/cmd/compile/internal/types2/testdata/fixedbugs/issue51233.go2 [new file with mode: 0644]
src/go/types/signature.go
src/go/types/testdata/fixedbugs/issue51232.go2 [new file with mode: 0644]
src/go/types/testdata/fixedbugs/issue51233.go2 [new file with mode: 0644]
test/typeparam/issue51232.go [new file with mode: 0644]
test/typeparam/issue51233.go [new file with mode: 0644]