]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/dist: fix bad LC_TIME assumption in 'date' invocation
authorAlberto Donizetti <alb.donizetti@gmail.com>
Thu, 2 Nov 2017 09:22:19 +0000 (10:22 +0100)
committerRuss Cox <rsc@golang.org>
Fri, 3 Nov 2017 13:42:33 +0000 (13:42 +0000)
commit6de53832ae7678f18e1b4077134764b11687992d
tree9837857fb57bbf1c295d1f8efbe30e77a960b497
parenteaf603601bf79216772ba36a9b981f21b50ade96
cmd/dist: fix bad LC_TIME assumption in 'date' invocation

With GOBUILDTIMELOGFILE set, make.bash logs the starting time using

  $ echo $(date) > file

and expects to be able to read the date back with

  time.Parse(time.UnixDate)

but in some locales the default date format is not the same as
time.UnixDate; for example on LC_TIME="en_GB.UTF-8"

  $ locale date_fmt
  %a %e %b %H:%M:%S %Z %Y

Fix this by setting LC_TIME=C before the date command invocation.

Fixes #22541

Change-Id: I59bf944bb868e2acdd816c7e35134780cdbfc6a6
Reviewed-on: https://go-review.googlesource.com/75370
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/make.bash