]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/trace: revert internal/traceparser
authorHana Kim <hyangah@gmail.com>
Mon, 19 Nov 2018 17:30:56 +0000 (12:30 -0500)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Thu, 22 Nov 2018 02:59:55 +0000 (02:59 +0000)
commit6d5caf38e37bf9aeba3291f1f0b0081f934b1187
treec44550792352d1698edc6ab9dec812758cc566ca
parent47df645473210267fd7512c5b92de00908198974
cmd/trace: revert internal/traceparser

The performance improvement is not as big as we hoped.
Until the API is feature complete, we postpone the release
and avoid added complexity.

This change was prepared by reverting all the changes affected
src/cmd/trace and src/internal/traceparser packages after
golang.org/cl/137635, and then bringing back MMU computation
APIs (originally in src/internal/traceparser) to the
src/internal/trace package.

Revert "cmd/trace: use new traceparser to parse the raw trace files"
This reverts https://golang.org/cl/145457
  (commit 08816cb8d7ed16b9c804587ff02c1ad1c3af6cd5).

Revert "internal/traceparser: provide parser that uses less space and parses segments of runtime trace files"
This reverts https://golang.org/cl/137635
  (commit daaf361f74c3665bcb364356c5a9dd9f536c78c3).

Change-Id: Ic2a068a7dbaf4053cd9674ca7bde9c58e74385b4
Reviewed-on: https://go-review.googlesource.com/c/150517
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
46 files changed:
misc/nacl/testzip.proto
src/cmd/trace/annotations.go
src/cmd/trace/annotations_test.go
src/cmd/trace/goroutines.go
src/cmd/trace/main.go
src/cmd/trace/mmu.go
src/cmd/trace/pprof.go
src/cmd/trace/trace.go
src/cmd/trace/trace_test.go
src/cmd/trace/trace_unix_test.go
src/go/build/deps_test.go
src/internal/trace/gc.go [moved from src/internal/traceparser/gc.go with 99% similarity]
src/internal/trace/gc_test.go [moved from src/internal/traceparser/gc_test.go with 89% similarity]
src/internal/trace/mud.go [moved from src/internal/traceparser/mud.go with 99% similarity]
src/internal/trace/mud_test.go [moved from src/internal/traceparser/mud_test.go with 99% similarity]
src/internal/traceparser/consistent.go [deleted file]
src/internal/traceparser/events.go [deleted file]
src/internal/traceparser/file.go [deleted file]
src/internal/traceparser/filebuf/filebuf.go [deleted file]
src/internal/traceparser/filebuf/filebuf_test.go [deleted file]
src/internal/traceparser/filebuf/fromreader.go [deleted file]
src/internal/traceparser/fuzz.go [deleted file]
src/internal/traceparser/goroutines.go [deleted file]
src/internal/traceparser/parser_test.go [deleted file]
src/internal/traceparser/raw.go [deleted file]
src/internal/traceparser/robust.go [deleted file]
src/internal/traceparser/testdata/06dfecf6e5dfb78e954e7892120b56bfca50af65-6.bad [deleted file]
src/internal/traceparser/testdata/0e6dd1787a6339366dac733a2f957a05d7aa3ac7-3.bad [deleted file]
src/internal/traceparser/testdata/16970d24ef6753d71953e20d10638705bdccc3ba-2.weird [deleted file]
src/internal/traceparser/testdata/26492441b33e1bb93669f79cf3584755cc3ef7e8-2.weird [deleted file]
src/internal/traceparser/testdata/2ccf452e473ded814ea880c602488637fc27e549.good [deleted file]
src/internal/traceparser/testdata/34f92cd2ae08f558c494b2ef79e80b574c9f096c-8.weird [deleted file]
src/internal/traceparser/testdata/4557f81f6aae617eeec8dd920997ea27b3dda12b.weird [deleted file]
src/internal/traceparser/testdata/495712b6e35ad7566869c887aa823fcbf69c0b80-1.weird [deleted file]
src/internal/traceparser/testdata/63cd688ddff425bbbc220fbb7bd4fa11616a8b64-1.bad [deleted file]
src/internal/traceparser/testdata/63df44bfc9d27851fb054ce03002e7e25f307e2f-5.weird [deleted file]
src/internal/traceparser/testdata/6aa1a69b265c3092972a2a81e77fbcaa87061735-4.bad [deleted file]
src/internal/traceparser/testdata/7b82e808a6a3471352a4197d44fedbe3f5fb6f77-1.bad [deleted file]
src/internal/traceparser/testdata/94347dc6ca9c22daec04c5f2530b16ea60bb0ba2-7.weird [deleted file]
src/internal/traceparser/testdata/9fa93c88557e64b0714b8849aacf713d17ff928e-2.weird [deleted file]
src/internal/traceparser/testdata/abf7185aaf1cb69fb5fae50ba8546a7cdefade57-2.weird [deleted file]
src/internal/traceparser/testdata/d28fcef078c7dc722867d781b1fd7f37ca965372-7.weird [deleted file]
src/internal/traceparser/testdata/d70f178a3813df03f2aed0d47f6d9bc844b8cb57-4.weird [deleted file]
src/internal/traceparser/testdata/e68c3126700dda2c2ac3b8743e9f319cb313042a-1.weird [deleted file]
src/internal/traceparser/tr.go [deleted file]
src/internal/traceparser/writer.go [deleted file]