]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.typeparams] cmd/compile/internal/types2: don't crash if import path is missing
authorRobert Griesemer <gri@golang.org>
Tue, 15 Dec 2020 01:23:00 +0000 (17:23 -0800)
committerRobert Griesemer <gri@golang.org>
Tue, 15 Dec 2020 19:44:38 +0000 (19:44 +0000)
commit6b18081d01f6f87b9af9e5b3910f1379d52a13eb
tree4d660d75989a3692c8e9d925ac3d5c4f4f470d6b
parent14e4267c3446fe30bb1c7a1a874dc7e18c1d38d1
[dev.typeparams] cmd/compile/internal/types2: don't crash if import path is missing

In package syntax:
- fix parser appendGroup to not add nil entries
- non-string paths are syntax errors per the spec; report in parser
- document ImportDecl.Path invariants

In package types2:
- guard against absent paths

In package gc:
- guard against absent paths

Fixes #43190.

Change-Id: Ic6a06f6a96b7f519feaa1ceaf4376fc5ab0f0129
Reviewed-on: https://go-review.googlesource.com/c/go/+/278114
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/gc/noder.go
src/cmd/compile/internal/syntax/nodes.go
src/cmd/compile/internal/syntax/parser.go
src/cmd/compile/internal/types2/fixedbugs/issue43190.src [new file with mode: 0644]
src/cmd/compile/internal/types2/resolver.go