]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile/internal/pgo: add hint to missing start_line error
authorMichael Pratt <mpratt@google.com>
Mon, 9 Jan 2023 18:59:54 +0000 (13:59 -0500)
committerMichael Pratt <mpratt@google.com>
Mon, 9 Jan 2023 21:50:54 +0000 (21:50 +0000)
commit64519baf3802f96a813f3f35e87aefa30a5f5f73
tree77d1ef16021b0fe5bd221aa92bc3d214f3127ea0
parent376076f3c6bed06f5256a316af8f1eed53a1135e
cmd/compile/internal/pgo: add hint to missing start_line error

Profiles only began adding Function.start_line in 1.20. If it is
missing, add a hint to the error message that they may need to profile a
build of the application built with a newer version of the toolchain.

Technically profiles are not required to come from Go itself (e.g., they
could be converted from perf), but in practice they most likely are.

Fixes #57674.

Change-Id: I87eca126d3fed0cff94bbb8dd748bd4652f88b12
Reviewed-on: https://go-review.googlesource.com/c/go/+/461195
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
src/cmd/compile/internal/pgo/irgraph.go