]> Cypherpunks.ru repositories - gostls13.git/commit
net/http: ensure Request.Body.Close is called once and only once
authorRoss Light <ross@zombiezen.com>
Sat, 26 Sep 2020 15:49:56 +0000 (08:49 -0700)
committerRuss Cox <rsc@golang.org>
Fri, 16 Oct 2020 16:53:27 +0000 (16:53 +0000)
commit606d4a38b9ae76df30cc1bcaeee79923a5792e59
treea4934607d4ad2c49af503a76539ededd69774df0
parentdfee3332e66bd3f3afd76615767d2cd9b1905b26
net/http: ensure Request.Body.Close is called once and only once

Makes *Request.write always close the body, so that callers no longer
have to close the body on returned errors, which was the trigger for
double-close behavior.

Fixes #40382

Change-Id: I128f7ec70415f240d82154cfca134b3f692191e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/257819
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Damien Neil <dneil@google.com>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
src/net/http/client_test.go
src/net/http/request.go
src/net/http/transfer.go
src/net/http/transport.go