]> Cypherpunks.ru repositories - gostls13.git/commit
net/http: use testenv.Command instead of exec.Command in tests
authorBryan C. Mills <bcmills@google.com>
Tue, 22 Aug 2023 15:01:29 +0000 (11:01 -0400)
committerGopher Robot <gobot@golang.org>
Tue, 22 Aug 2023 18:18:19 +0000 (18:18 +0000)
commit5dda49037209290519f4881a0080caaef025bbd7
tree2a251ff1fdaf4000831a666e82c58384a8eec18f
parent282cd561bbfceef2e32847212cc535dc888143d9
net/http: use testenv.Command instead of exec.Command in tests

On Unix platforms, testenv.Command sends SIGQUIT to stuck commands
before the test times out. For subprocesses that are written in Go,
that causes the runtime to dump running goroutines, and in other
languages it triggers similar behavior (such as a core dump).
If the subprocess is stuck due to a bug (such as #57999), that may
help to diagnose it.

For #57999.

Change-Id: Ia2e9d14718a26001e030e162c69892497a8ebb21
Reviewed-on: https://go-review.googlesource.com/c/go/+/521816
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
src/net/http/cgi/host_test.go
src/net/http/fs_test.go
src/net/http/http_test.go
src/net/http/serve_test.go