]> Cypherpunks.ru repositories - gostls13.git/commit
go/types, types2: distinguish between substring and regexp error patterns
authorRobert Griesemer <gri@golang.org>
Fri, 9 Dec 2022 00:20:37 +0000 (16:20 -0800)
committerGopher Robot <gobot@golang.org>
Tue, 17 Jan 2023 19:54:27 +0000 (19:54 +0000)
commit5cd805c6df5c8988ea07e2ec1e4c52574b40bbf1
tree47c7ace6920026b03cb9a259dddd9c5e654955e8
parentb003ee499a97f28a1328a8eaeb380596fad5788b
go/types, types2: distinguish between substring and regexp error patterns

Use ERROR for substrings, and ERRORx for regexp error patterns.
Correctly unquote patterns for ERROR and ERRORx.
Adjust all tests in internal/types/testdata and locally as needed.

The changes to internal/types/testdata were made through
repeated applications of regexpr find/replace commands
and manual cleanups.

Fixes #51006.

Change-Id: Ib9ec5001243b688bf5aee56b7d4105fb55999ab4
Reviewed-on: https://go-review.googlesource.com/c/go/+/455755
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
99 files changed:
src/cmd/compile/internal/types2/check_test.go
src/cmd/compile/internal/types2/testdata/local/issue47996.go
src/go/types/check_test.go
src/go/types/commentMap_test.go
src/go/types/issues_test.go
src/internal/types/testdata/check/builtins0.go
src/internal/types/testdata/check/builtins1.go
src/internal/types/testdata/check/conversions1.go
src/internal/types/testdata/check/decls0.go
src/internal/types/testdata/check/decls1.go
src/internal/types/testdata/check/decls2/decls2a.go
src/internal/types/testdata/check/decls2/decls2b.go
src/internal/types/testdata/check/decls3.go
src/internal/types/testdata/check/errors.go
src/internal/types/testdata/check/expr0.go
src/internal/types/testdata/check/expr1.go
src/internal/types/testdata/check/expr2.go
src/internal/types/testdata/check/expr3.go
src/internal/types/testdata/check/go1_12.go
src/internal/types/testdata/check/importC.go
src/internal/types/testdata/check/importdecl0/importdecl0b.go
src/internal/types/testdata/check/importdecl1/importdecl1b.go
src/internal/types/testdata/check/issues0.go
src/internal/types/testdata/check/issues1.go
src/internal/types/testdata/check/methodsets.go
src/internal/types/testdata/check/shifts.go
src/internal/types/testdata/check/stmt0.go
src/internal/types/testdata/check/typeinference.go
src/internal/types/testdata/check/typeinst1.go
src/internal/types/testdata/check/typeparams.go
src/internal/types/testdata/check/vardecl.go
src/internal/types/testdata/examples/constraints.go
src/internal/types/testdata/examples/inference.go
src/internal/types/testdata/examples/methods.go
src/internal/types/testdata/examples/types.go
src/internal/types/testdata/examples/typesets.go
src/internal/types/testdata/fixedbugs/54942.go
src/internal/types/testdata/fixedbugs/issue28251.go
src/internal/types/testdata/fixedbugs/issue39634.go
src/internal/types/testdata/fixedbugs/issue39725.go
src/internal/types/testdata/fixedbugs/issue39754.go
src/internal/types/testdata/fixedbugs/issue39976.go
src/internal/types/testdata/fixedbugs/issue40350.go
src/internal/types/testdata/fixedbugs/issue41124.go
src/internal/types/testdata/fixedbugs/issue42881.go
src/internal/types/testdata/fixedbugs/issue42987.go
src/internal/types/testdata/fixedbugs/issue43087.go
src/internal/types/testdata/fixedbugs/issue43109.go
src/internal/types/testdata/fixedbugs/issue43110.go
src/internal/types/testdata/fixedbugs/issue43124.go
src/internal/types/testdata/fixedbugs/issue43190.go
src/internal/types/testdata/fixedbugs/issue43671.go
src/internal/types/testdata/fixedbugs/issue45114.go
src/internal/types/testdata/fixedbugs/issue45920.go
src/internal/types/testdata/fixedbugs/issue46583.go
src/internal/types/testdata/fixedbugs/issue47031.go
src/internal/types/testdata/fixedbugs/issue47115.go
src/internal/types/testdata/fixedbugs/issue47411.go
src/internal/types/testdata/fixedbugs/issue47747.go
src/internal/types/testdata/fixedbugs/issue47818.go
src/internal/types/testdata/fixedbugs/issue47968.go
src/internal/types/testdata/fixedbugs/issue48008.go
src/internal/types/testdata/fixedbugs/issue48312.go
src/internal/types/testdata/fixedbugs/issue48472.go
src/internal/types/testdata/fixedbugs/issue48827.go
src/internal/types/testdata/fixedbugs/issue49005.go
src/internal/types/testdata/fixedbugs/issue49112.go
src/internal/types/testdata/fixedbugs/issue49179.go
src/internal/types/testdata/fixedbugs/issue49242.go
src/internal/types/testdata/fixedbugs/issue49247.go
src/internal/types/testdata/fixedbugs/issue49296.go
src/internal/types/testdata/fixedbugs/issue49482.go
src/internal/types/testdata/fixedbugs/issue49579.go
src/internal/types/testdata/fixedbugs/issue49602.go
src/internal/types/testdata/fixedbugs/issue49735.go
src/internal/types/testdata/fixedbugs/issue49739.go
src/internal/types/testdata/fixedbugs/issue50372.go
src/internal/types/testdata/fixedbugs/issue50417.go
src/internal/types/testdata/fixedbugs/issue50782.go
src/internal/types/testdata/fixedbugs/issue50816.go
src/internal/types/testdata/fixedbugs/issue50918.go
src/internal/types/testdata/fixedbugs/issue50929.go
src/internal/types/testdata/fixedbugs/issue50965.go
src/internal/types/testdata/fixedbugs/issue51229.go
src/internal/types/testdata/fixedbugs/issue51232.go
src/internal/types/testdata/fixedbugs/issue51335.go
src/internal/types/testdata/fixedbugs/issue51376.go
src/internal/types/testdata/fixedbugs/issue51472.go
src/internal/types/testdata/fixedbugs/issue51610.go
src/internal/types/testdata/fixedbugs/issue51658.go
src/internal/types/testdata/fixedbugs/issue52031.go
src/internal/types/testdata/fixedbugs/issue53358.go
src/internal/types/testdata/fixedbugs/issue56351.go
src/internal/types/testdata/fixedbugs/issue57486.go
src/internal/types/testdata/fixedbugs/issue57500.go
src/internal/types/testdata/spec/assignability.go
src/internal/types/testdata/spec/comparable1.19.go
src/internal/types/testdata/spec/comparisons.go
src/internal/types/testdata/spec/conversions.go