]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile/internal/types2: partial revert of incorrect unification "fix"
authorRobert Griesemer <gri@golang.org>
Thu, 7 Oct 2021 22:53:32 +0000 (15:53 -0700)
committerRobert Griesemer <gri@golang.org>
Fri, 8 Oct 2021 00:24:51 +0000 (00:24 +0000)
commit5780be401fbf1c4766f45301e727fde4a89ac2cc
tree682f0bf321b3cc066819b57af7cf9a9446adad07
parent7cef83162bbe0008f3e158297b94a7dead64a9b1
cmd/compile/internal/types2: partial revert of incorrect unification "fix"

The "fix" (CL 352832) for #48619 was incorrect and broke
the unification algorithm in some cases (e.g., #48695).

This CL reverts the changes made by CL 352832 to unify.go,
and comments out code in corresponding tests.

As a result, #48695 will be fixed, and we will re-open #48619.

Fixes #48695.
For #48619.
For #48656.

Change-Id: I91bc492062dbcc8dae7626f6b33f6dfabf48bcb8
Reviewed-on: https://go-review.googlesource.com/c/go/+/354690
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/types2/testdata/fixedbugs/issue48619.go2
src/cmd/compile/internal/types2/testdata/fixedbugs/issue48656.go2
src/cmd/compile/internal/types2/testdata/fixedbugs/issue48695.go2 [new file with mode: 0644]
src/cmd/compile/internal/types2/unify.go