]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.21] cmd/link: avoid deadcode of global map vars for programs...
authorThan McIntosh <thanm@google.com>
Wed, 6 Sep 2023 14:15:37 +0000 (10:15 -0400)
committerThan McIntosh <thanm@google.com>
Wed, 20 Sep 2023 16:24:52 +0000 (16:24 +0000)
commit556e9c36baad127ec34be5d2f7e29ae5fd594dcf
tree9797b300d07dd355c15ca048536858a4bec49a2a
parentb64dc5f499400f1ec3ef0192cc2d42a87a1916a8
[release-branch.go1.21] cmd/link: avoid deadcode of global map vars for programs using plugins

If a program imports the plugin package, the mechanisms in place for
detecting and deleting unused global map variables are no longer safe,
since it's possibly for a given global map var to be unreferenced in
the main program but referenced by a plugin. This patch changes the
linker to test for plugin use and to avoid removing any unused global
map variables if the main program could possibly load up a plugin.

Fixes #62505.
Updates #62430.

Change-Id: Ie00b18b681cb0d259e3c859ac947ade5778cd6c8
(cherry picked from commit 660620dd45dc11f2d889add79bedf2dc771c7d04)
Reviewed-on: https://go-review.googlesource.com/c/go/+/526575
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/cgo/internal/testplugin/plugin_test.go
src/cmd/cgo/internal/testplugin/testdata/issue62430/main.go [new file with mode: 0644]
src/cmd/cgo/internal/testplugin/testdata/issue62430/plugin.go [new file with mode: 0644]
src/cmd/link/internal/ld/deadcode.go