]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: optimize shift ops on arm64 when the shift value is v&63
authorruinan <ruinan.sun@arm.com>
Mon, 8 Aug 2022 04:17:19 +0000 (04:17 +0000)
committerGopher Robot <gobot@golang.org>
Fri, 2 Sep 2022 17:44:29 +0000 (17:44 +0000)
commit54c7bc9cff748e6554e53fbbbf823fdd214d0482
tree8520677a7dc976ac69c6c28b213f57c831be27d5
parent5befb24bb5cbd8ae6210b4d6a88a4437eec6fb0b
cmd/compile: optimize shift ops on arm64 when the shift value is v&63

For the following code case:

  var x uint64
  x >> (shift & 63)

We can directly genereta `x >> shift` on arm64, since the hardware will
only use the bottom 6 bits of the shift amount.

Benchmark               old time/op  new time/op    delta
ShiftArithmeticRight-8  0.40ns       0.31ns        -21.7%

Change-Id: Id58c8a5b2f6dd5c30c3876f4a36e11b4d81e2dc9
Reviewed-on: https://go-review.googlesource.com/c/go/+/425294
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/compile/internal/ssa/gen/ARM64.rules
src/cmd/compile/internal/ssa/rewriteARM64.go
test/codegen/shift.go