]> Cypherpunks.ru repositories - gostls13.git/commit
net/http: remove arbitrary timeouts in tests of Server.ErrorLog
authorBryan C. Mills <bcmills@google.com>
Thu, 2 Nov 2023 14:29:08 +0000 (10:29 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 2 Nov 2023 20:15:19 +0000 (20:15 +0000)
commit547eb8d699a63512cf58c7eeae5517ead7debf50
treef6b4f8053b6b1f4a2a14d24eb1b3959c165fc106
parent39d3c4ad35984b470b2928a37ea4a7e721b1225a
net/http: remove arbitrary timeouts in tests of Server.ErrorLog

This also allows us to remove the chanWriter helper from the test,
using a simpler strings.Builder instead, relying on
clientServerTest.close for synchronization.
(I don't think this runs afoul of #38370, because the handler
functions themselves in these tests should never be executed,
let alone result in an asynchronous write to the error log.)

Fixes #57599.

Change-Id: I45c6cefca0bb218f6f9a9659de6bde454547f704
Reviewed-on: https://go-review.googlesource.com/c/go/+/539436
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/net/http/client_test.go
src/net/http/serve_test.go