]> Cypherpunks.ru repositories - gostls13.git/commit
run.bat: use cmd/dist instead of 'go install' to rebuild std and cmd
authorBryan C. Mills <bcmills@google.com>
Fri, 1 Apr 2022 19:36:17 +0000 (15:36 -0400)
committerBryan Mills <bcmills@google.com>
Tue, 5 Apr 2022 14:18:19 +0000 (14:18 +0000)
commit5210a7128563e64952d432a0efd2d38c32cd090c
treef96bcb2ff9fc2a97ce999ae772ec75b38f37eb51
parent592078ff3f7d938b2fbcd98ddcb72e0d2748fdb1
run.bat: use cmd/dist instead of 'go install' to rebuild std and cmd

cmd/dist may set and/or unset variables before building, and at any
rate it is fragile to run 'go install' before sourcing env.bat.

The build-stamp information embedded by the 'go' command is currently
sensitive to whether CGO_* variables are implicit or explicit, so running
'go install' before env.bat may cause stamped metadata to become stale.
(Explicitly setting to the default arguably ought to produce the same
metadata as leaving the variables unset, but that's a separate issue
and a bigger cleanup.)

Moreover, run.bat is supposed to parallel run.bash, and run.bash
already hasn't invoked 'go install' itself since CL 6531!

For #52009

Change-Id: Ie35217913f02cc7e0c3f9b12874abd7416473478
Reviewed-on: https://go-review.googlesource.com/c/go/+/398060
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/run.bat