]> Cypherpunks.ru repositories - gostls13.git/commit
runtime: perform debug call injection on a new goroutine
authorAustin Clements <austin@google.com>
Wed, 15 Apr 2020 19:38:00 +0000 (15:38 -0400)
committerAustin Clements <austin@google.com>
Wed, 29 Apr 2020 21:29:11 +0000 (21:29 +0000)
commit3633d2c545cf21c2803103e1036f17f19b4ae6fa
tree553534fde5b03bcf11b4fb0747efad61a1d15e82
parentb3863fbbc2fe1dbf516111992854aa9178d01410
runtime: perform debug call injection on a new goroutine

Currently, when a debugger injects a call, that call happens on the
goroutine where the debugger injected it. However, this requires
significant runtime complexity that we're about to remove.

To prepare for this, this CL switches to a different approach that
leaves the interrupted goroutine parked and runs the debug call on a
new goroutine. When the debug call returns, it resumes the original
goroutine.

This should be essentially transparent to debuggers. It follows the
exact same call injection protocol and ensures the whole protocol
executes indivisibly on a single OS thread. The only difference is
that the current G and stack now change part way through the protocol.

For #36365.

Change-Id: I68463bfd73cbee06cfc49999606410a59dd8f653
Reviewed-on: https://go-review.googlesource.com/c/go/+/229299
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/runtime/debugcall.go
src/runtime/export_debug_test.go
src/runtime/runtime2.go