]> Cypherpunks.ru repositories - gostls13.git/commit
go/types, types2: consolidate helper functions for tests (cleanup)
authorRobert Griesemer <gri@golang.org>
Tue, 18 Oct 2022 19:34:50 +0000 (12:34 -0700)
committerGopher Robot <gobot@golang.org>
Wed, 19 Oct 2022 22:01:11 +0000 (22:01 +0000)
commit27f094b17cf1e0495515614476ec9137c0ed0a82
tree47bfcdce04c93e652443e40a2ec1d203e1ef4c19
parent35e54da99640110845086d30ba0b8f69a3ebd3c2
go/types, types2: consolidate helper functions for tests (cleanup)

Instead of having various inconsistent helper functions, rely on
4 helper functions with consistent naming and parameters:

- parse and mustParse
- typecheck and mustTypecheck

Panic rather than call t.Fatal in the mustX functions to simplify
their use.

Use the new functions in tests consistently.

Change-Id: Ib19dc5cc470b51512c23c09df32c379dc3eb8f4b
Reviewed-on: https://go-review.googlesource.com/c/go/+/443757
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
21 files changed:
src/cmd/compile/internal/types2/api_test.go
src/cmd/compile/internal/types2/example_test.go
src/cmd/compile/internal/types2/instantiate_test.go
src/cmd/compile/internal/types2/issues_test.go
src/cmd/compile/internal/types2/named_test.go
src/cmd/compile/internal/types2/object_test.go
src/cmd/compile/internal/types2/resolver_test.go
src/cmd/compile/internal/types2/sizes_test.go
src/cmd/compile/internal/types2/stdlib_test.go
src/cmd/compile/internal/types2/typestring_test.go
src/go/types/api_test.go
src/go/types/example_test.go
src/go/types/instantiate_test.go
src/go/types/issues_test.go
src/go/types/methodset_test.go
src/go/types/named_test.go
src/go/types/object_test.go
src/go/types/resolver_test.go
src/go/types/sizes_test.go
src/go/types/stdlib_test.go
src/go/types/typestring_test.go